Seeding Input: Test Seeding Log Creation

DickinsonCollege / FD2School-FarmData2-S23

A fork of FarmData2 that is used for the FarmData2 School Activities.

Other

1 stars 36 forks source link

Seeding Input: Test Seeding Log Creation #224

Open JinLeeGG opened 1 year ago

JinLeeGG commented 1 year ago

Pull Request Description

Addresses #203

Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

won369369 commented 1 year ago

@won369369 Self-assigning to track this PR easily on the mentioned PR page.

johnmaccormick commented 1 year ago

Very nice solution to a challenging test scenario. I think this will be ready to merge once you add a general comment at the top of the file.

johnmaccormick commented 1 year ago

I'm seeing a few failed tests here. The first failure produces the message:

1) Tests for SeedingInput log creation
       Checks all of the input elements in the form remain populated with their existing values in direct seeding:
     CypressError: Timed out retrying after 10000ms: `cy.select()` failed because it could not find a single `<option>` with value, index, or text matching: `ARUGULA`

Can you confirm that all tests pass when you run them? (Also check you have all latest changes from upstream main) Thanks!

braughtg commented 1 year ago

All of the tests passed for me.

@johnmaccormick have you reviewed this PR again?