search

DickinsonCollege / FD2School-FarmData2-S23

A fork of FarmData2 that is used for the FarmData2 School Activities.
Other
1 stars 36 forks source link

Main fd2 tabs test #228

Closed nmqng closed 1 year ago

nmqng commented 1 year ago

Pull Request Description

Address #199

Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

johnmaccormick commented 1 year ago

@jamesng5 @vuphuongha @tainguyen103 -- I haven't looked at your changes yet. I will examine those and comment separately about it. Meanwhile, there is something you need to fix with your PR. This PR should have only one changed file -- fd2tabsexistence.spec.js

The other changed files are part of a different change for a different issue, right? Therefore, you need to base your feature branch for this PR off the main branch, not a previous feature branch.

Please try to fix this on your own but if you need a hint of how to manipulate the branches and files, let me know and I will provide assistance.

johnmaccormick commented 1 year ago

Another comment: the file name for your test is hard to read. Please use camel case to make it more readable. Let me know if you need additional explanation of this. Good luck making these additional changes and getting your PR merged -- excellent progress so far!

johnmaccormick commented 1 year ago

nice work! -- everything looks great -- merging now.