Open braughtg opened 11 months ago
braughtg
commented
11 months ago Potentially split this issue into two. One for adding the payload to the edit-clicked event and testing that. This can be done independent of any other changes as the payload will just be ignored by current code. Then a second issue, for using that payload in the seeding report page to make the dropdown menus for area and crops context sensitive.
braughtg
commented
11 months ago The edited-click changes mentioned in the issue are no longer necessary to fulfill this issue but are necessary to complete it. That is, this issue should follow after the closing of #588.
braughtg
commented
11 months ago The
edited-clickchanges mentioned in the issue are no longer necessary to fulfill this issue but are necessary to complete it. That is, this issue should follow after the closing of #588.
This condition has been met via the merging of #604. I'll take a look at this issue.
braughtg
commented
11 months ago Would it be worthwhile to create a separate issue for filtering areas in the Transplanting report so only field areas are displayed? Since the seeds have been transplanted there shouldn't be an option for users to change the area back to a greenhouse area.
This issue should be addressed after issue #588 has been closed.
Current Functionality
When you edit a row in the Seeding Report page all crops and areas are listed in the dropdowns. This doesn't make sense because it allows users to place a tray seeding in a field area while also allowing a direct seeding change the area to designated tray seeding spaces.
Additionally, some crops are exclusively tray/direct seeded, so users shouldn't be allowed to change a tray seeding to a crop that's exclusively direct seeded and vice-versa for direct seeding.Desired Functionality
Some filterable functionality needs to be added into the computed methods of the Seeding Report page that changes the dropdown options according to the log's seeding type. If it's a direct seeding only display the possible, relevant options for direct seedings and vice-versa for tray seeding.
This will require changes to the CustomTableComponent.js which will necessitate updates to the CustomTableComponent.spec.comp.js to test this new functionality. The changes would be adding a payload to theedit-clickedemit so that it emits theidof the log being edited. Then the parent page can determine the options of the dropdown based on some information located in that log's data (in this case, the seeding type).Greater Issue
This issue deals with some of the questions asked in issue #466.
What should be editable? This applies to many things in the project: columns in the report pages, the flow of editing (i.e when a planting log is changed does its associated logs update? Should you even be able to update planting logs?). There are many questions surrounding editing that need to be addressed as a whole moving forward so that we follow good practices in pages and avoid larger problems of creating inconsistent logs.
Author's Note
This issue has been changed to only address filtering areas. Although there are crops that are directly seeded into the ground and directly seeded into the greenhouse, we haven't had that conversation yet and implementing that feature would require some additional conversations about potentially modifying crops to contain some additional data to that details whether they're strictly tray/direct seeds. Additionally, maybe we allow admins to have a list they can modify that's available to all pages that details which seeds are tray/direct only. Hence, this is a much larger topic that needs to be discussed as team and with input from Matt to gain some insights on crop seeding.