DickinsonCollege / FarmData2

FarmData2 provides support for the operation and certification requirements of small organic farming operations.
Other
18 stars 137 forks source link

BarnKit Seeding Report Default for Seeding Type Filter #658

Closed braughtg closed 1 year ago

braughtg commented 1 year ago

Currently when a Seeding Report is generated the Seeding Type displayed defaults to "All" even if there are no Direct Seedings or Tray Seedings. Would it be more useful to have the report automatically detect what types of seedings actually appear in the report and then default to Direct Seedings, Tray Seedings or All?

FutzMonitor commented 1 year ago

Depending on what option is selected in the "Seeding type" filter the look of the table defaults to three different views:

  1. When ALL is selected - A general view that omits specific data relating to direct and tray seedings.
  2. When Direct Seeding is selected - A filtered view of only direct seedings with additional information for those types of seedings.
  3. When Tray Seeding is selected -- A filtered view of only tray seedings with additional information for those types of seedings.

I think it would be best for the user if the table could detect if there is only one type of seeding within that date range and to select that view for the user by default. For example, in the below image there are only direct seedings: image

It is unnecessary to display the tray seeding summary table and additional information about the direct seeding logs are hidden from the user because the ALL option is selected.

In my opinion, it would be more beneficial for the user to arrive at this view by default in this situation: image

It saves a click, and it immediately displays all information present when only one seeding type appears.

Mikek16 commented 1 year ago

This issue seems like it would be a good first or second issue, however if we don't want to reserve it I have a fix in mind and would like to work on this issue.

braughtg commented 1 year ago

Super. I've assigned the issue to you. Get back in touch here if you have questions.

Mikek16 commented 1 year ago

@braughtg pr #680 is ready for review, let me know if there are any necessary changes.