Refactored dev/startup.bash Docker container

DickinsonCollege / FarmData2

FarmData2 provides support for the operation and certification requirements of small organic farming operations.

Other

18 stars 137 forks source link

Refactored dev/startup.bash Docker container #682

Closed WarpWing closed 11 months ago

WarpWing commented 12 months ago

Pull Request Description

As part of my crusade to resolve #655, the actual dev container script is going to take some time to analyze but I figured I would start with the smallest fish and take a look at the actual startup script inside the dev container. I mostly reworded some of the comments to be clearer and used a single 'sudo' command with a here-document to reduce footprint. It's a small portion, I would imagine it will take a while to actually speed up the container but every little bit helps!

Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

JingyuMarcelLee commented 12 months ago

Tested PR. Dev environment started without issues on WSL2 w/ Docker desktop.

braughtg commented 12 months ago

Tested PR. Dev environment started without issues on WSL2 w/ Docker desktop.

Awesome - Thanks Marcel! I've given you Triage access to the repo so that you can mark off an official review of the PR if you have a chance. Thanks!

braughtg commented 12 months ago

Anyone else having a look at this PR you should:

Fetch the PR
- git fetch origin pull/<ID>/head:<BRANCHNAME>
- <ID> is the number of the PR
- <BRANCHNAME> is a name you give to the branch for the PR in your local repo.
switch to <BRANCHNAME>
Start FarmData2
Confirm some basic functionality of the Dev Environment.
- Install the sample database
- Open FarmData2
- Create a seeding log and verify it exits
- Open VS Code
- Run some tests
- cd FarmData2/farmdata2
- ./test_runner.bash ct (Note: they may be out of date and not all may pass but Cypress should run).

FutzMonitor commented 12 months ago

I will try to get to this review this weekend.

FutzMonitor commented 12 months ago

Everything is working well on my Windows 10 laptop using WSL2 with Docker Desktop.

braughtg commented 11 months ago

@FutzMonitor

Everything is working well on my Windows 10 laptop using WSL2 with Docker Desktop.

Please check of your approval of the PR on your review and I'll merge it. Thanks!