Open DiddiLeija opened 2 months ago
Is your feature request related to a problem? Please describe.
Our format Nox session only uses ruff check [files] --fix to "format" our codebase:
format
ruff check [files] --fix
https://github.com/DiddiLeija/diddi-and-the-bugs/blob/93e6ca8e36270ec4ff25bee557230438b53b0a92/noxfile.py#L17-L21
However, this is a misunderstanding of the ruff check command, as it only fixes any critical thing, but no formatting happens at all.
ruff check
Describe the solution you'd like
Adding a session.run call to this function:
session.run
https://github.com/DiddiLeija/diddi-and-the-bugs/blob/93e6ca8e36270ec4ff25bee557230438b53b0a92/noxfile.py#L17-L18
to run the ruff format command on our files. It's not necessary to delete the ruff check --fix line, as it could be useful too.
ruff format
ruff check --fix
Describe alternatives you've considered
Stick to the check --fix-only formatting, but this is not recommended.
check --fix
Additional context
This is a Good First Issue, so I'd love to see a new contributor taking on this ticket!
If you need help with coding Nox sessions, you might find this documentation useful :hugs:
Is your feature request related to a problem? Please describe.
Our
format
Nox session only usesruff check [files] --fix
to "format" our codebase:https://github.com/DiddiLeija/diddi-and-the-bugs/blob/93e6ca8e36270ec4ff25bee557230438b53b0a92/noxfile.py#L17-L21
However, this is a misunderstanding of the
ruff check
command, as it only fixes any critical thing, but no formatting happens at all.Describe the solution you'd like
Adding a
session.run
call to this function:https://github.com/DiddiLeija/diddi-and-the-bugs/blob/93e6ca8e36270ec4ff25bee557230438b53b0a92/noxfile.py#L17-L18
to run the
ruff format
command on our files. It's not necessary to delete theruff check --fix
line, as it could be useful too.Describe alternatives you've considered
Stick to the
check --fix
-only formatting, but this is not recommended.Additional context
This is a Good First Issue, so I'd love to see a new contributor taking on this ticket!
If you need help with coding Nox sessions, you might find this documentation useful :hugs: