search

DieReicheErethons / Brewery

GNU General Public License v3.0
161 stars 184 forks source link

[Issue] ExoticGarden Fruits Not Working #414

Open Zykana opened 3 years ago

Zykana commented 3 years ago

So ExoticGarden fruits are unable to be put into cauldrons. No errors or anything, just won't do it.

I am using Spigot 1.17, and Exotic Garden Dev 76.

Sn0wStorm commented 3 years ago

Did you put the id of the fruits into a recipe?

Zykana commented 3 years ago

Yes, did how we format the ID change?

Sn0wStorm commented 3 years ago

No unless something in SlimeFun or Exotic Garden changed, it should still be the same. I'll look into it

Zykana commented 3 years ago

I'm unable to use even non-slimefun heads. I think perhaps a plugin might be interfering here.

SFGoose commented 3 years ago

I'm having the same issue, did you ever figure out the problem?

Zykana commented 3 years ago

I'm having the same issue, did you ever figure out the problem?

No I did not. :(

CloneCluke commented 3 years ago

I am also having this problem; Normal Slimefun items appear to be working, but none of the exotic garden. Anyone have a fix? I use exotic garden in close to 200 of my recipes.

ElNico56 commented 3 years ago

i'm having the same problem, no slimefun items work!

TristanVdElzen commented 3 years ago

I've done some testing and it appears that all non-vanilla items that are consumable can no longer be added to cauldrons. This includes:

My thinking is that the right-click event starts item consumption without checking if the target block is interactable.

Edit: solving this issue would likely also solve #421 as it pertains to the same operation.

CloneCluke commented 3 years ago

I've done some testing and it appears that all non-vanilla items that are consumable can no longer be added to cauldrons. This includes:

* brews from the brewery plugin

* Slimefun consumable items

* ExoticGardens consumable items (e.g. yeast and cornmeal works fine, but grapes or grape juice does not)

My thinking is that the right-click event starts item consumption without checking if the target block is interactable.

Edit: solving this issue would likely also solve #421 as it pertains to the same operation.

I noticed the same thing; however there was one particular consumable from Slimefun that worked for some reason. Still have not managed to find a work around

ElNico56 commented 3 years ago

It's not interactivity, since brewery brews can be used in further recipes (tested using last update on both as of the writting) it's slimefun specifically that breaks

TristanVdElzen commented 3 years ago

It's not interactivity, since brewery brews can be used in further recipes (tested using last update on both as of the writting) it's slimefun specifically that breaks

You are right! I tested some more, turns out my mistake with the brews was that I used the brew ID in my recipes. -facepalm- When an existing brew is used in a recipe specified by name it will work. :)

Issue remains for Slimefun and ExoticGarden consumable items, which as you pointed out is a fault in their code. Using those items on the cauldron does not trigger the Brewery clickCauldron() function.

TristanVdElzen commented 3 years ago

Fixed in ExoticGarden pull request: https://github.com/TheBusyBiscuit/ExoticGarden/pull/217 Requires Brewery pull request #435 in order to work.

Sn0wStorm commented 2 years ago

Im guessing this commit also fixes the issue. https://github.com/DieReicheErethons/Brewery/commit/db428892e91e9565e50ce4123ed2afbb70eac68e