search

DiederikvandenB / apollo-link-sentry

Apollo Link middleware which enriches SentryJS with GraphQL data
MIT License
123 stars 36 forks source link

Stop using Severity enum #431

Closed JavierMartinz closed 2 years ago

JavierMartinz commented 2 years ago

https://github.com/getsentry/sentry-javascript/pull/4926

spawnia commented 2 years ago

Please validate your changes locally and make sure CI passes - see https://github.com/DiederikvandenB/apollo-link-sentry/blob/master/CONTRIBUTING.md

danyonedwards commented 2 years ago

Hey, just to help move this PR along. Looks the migration guide expects you to use the string value now not the enum. https://github.com/getsentry/sentry-javascript/blob/master/MIGRATION.md#severity-severitylevel-and-severitylevels

E.G. SeverityLevel.Error should just be the string literal 'error' now.

JavierMartinz commented 2 years ago

Yeah, that's why I'm using SeverityLevel, because SeverityLevel.Error === 'error'.

The issue here is we need to bump @sentry/browser dependency.

spawnia commented 2 years ago

You can make whatever changes are required to make this pull request pass.

spawnia commented 2 years ago

See failing test in https://github.com/DiederikvandenB/apollo-link-sentry/runs/6830041476?check_suite_focus=true#step:5:41

JavierMartinz commented 2 years ago

Yeah, that test is failing because of the options type, which is inherited from https://github.com/wix/sentry-testkit and it looks like they didn't add support for Sentry 7 yet.

spawnia commented 2 years ago

Are we stuck waiting for https://github.com/wix/sentry-testkit/issues/108 or can we work around this issue?

JavierMartinz commented 2 years ago

I think we can wait for https://github.com/wix/sentry-testkit/pull/109

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: