Diego81 / omnicontacts

A generalized Rack middleware for importing contacts from major email providers.
477 stars 231 forks source link

remove extra step for parsing facebook response as was returning nil #175

Open mlennie opened 7 years ago

mlennie commented 7 years ago

This fixes this issue https://github.com/Diego81/omnicontacts/issues/170 Extra Facebook parse step was causing issue

lethunder commented 7 years ago

Hey @mlennie

did you succeed to use facebook connector?

i have this on my side

Missing redirect_uri parameter

Thanks in advance

mlennie commented 7 years ago

@lethunder yes my PR fixes the problem for me. https://github.com/Diego81/omnicontacts/pull/175/commits/d4849463a7fbb08165dbbe7b985075ee91a16e38

lethunder commented 7 years ago

@mlennie thanks

lethunder commented 7 years ago

Hey @mlennie , i still have issue with facebook even with your PR i have this Missing redirect_uri parameter.

this is my fork url https://github.com/lethunder/omnicontacts