Undefined Offset error when viewing objects with no parent collection

DiegoPino / islandora_piwik

Piwik integration module for Islandora

GNU General Public License v3.0

5 stars 3 forks source link

Undefined Offset error when viewing objects with no parent collection #19

Closed bondjimbond closed 6 years ago

bondjimbond commented 7 years ago

This happens when viewing a Newspaper Page object; I believe it's because these pages are not in any Collections.

Notice: Undefined offset: 0 in islandora_piwik_get_ancestor_collections() (line 255 of /var/www/drupal7/sites/all/modules/islandora_piwik/islandora_piwik.module).

mjordan commented 7 years ago

Would you be able to open a PR to fix this? Wrapping that line 255 in an `if (count($results)) {} check might be enough.

DiegoPino commented 6 years ago

Resolved via https://github.com/DiegoPino/islandora_piwik/issues/19