Some improvements: Solr based queries, javascript client, customDimensions

[DiegoPino]

This pull request adds a few improvements (in production for a year already) for Piwik integration Including:

• Javascript client to Piwik. Alternative to the PHP client (faster page load)
• Solr queries sometimes instead of SPARQL (faster)
• customDimensions instead of variables. (new PIWIK Logic)

[mjordan]

@DiegoPino I'm very happy that you've been using this module! I'll try to give it a smoke test in the next couple of days.

[DiegoPino]

@mjordan, sorry, sloppy of me, that was my debug branch. Will address all your very valid concerns. Your module is awesome and i have been using it at least for a year. Thanks El El lun, 28 de ago. de 2017 a las 17:18, Mark Jordan < notifications@github.com> escribió:

@DiegoPino https://github.com/diegopino I'm very happy that you've been using this module! I'll try to give it a smoke test in the next couple of days.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/mjordan/islandora_piwik/pull/20#issuecomment-325484955, or mute the thread https://github.com/notifications/unsubscribe-auth/AGn856lubt5AOzPUujG9yuPxEN27X4Ayks5scy6egaJpZM4PEl2_ .

-- Diego Pino Navarro Digital Repositories Developer Metropolitan New York Library Council (METRO)

[DiegoPino]

@mjordan i don´t see the dpm() statements you mentioned. Since I basically pulled my whole 7.x dev branch, and single/partial commits had dpm(), that could maybe be confusing?. But the final result (file changed) has no debug statements. Would you prefer me closing this one, squashing locally and making a unified pull request with a single commit in it? Can do of course. 😄

[mjordan]

I made the inline comments about dpm() in a commit (listed under the PR 'Commits' tab), e.g. https://github.com/mjordan/islandora_piwik/pull/20/commits/b5c56eafc5e39938d2ffe698381154b1c949da8f. Sorry about that. If you removed the lines I commented on in a subsequent commit, it makes sense that they wouldn't show up in the final PR. Please disregard thos comments. No need to squash.

[bondjimbond]

@mjordan Are you planning to merge this, or is there still work to do?

[mjordan]

Hi @bondjimbond I plan to merge it but haven't had time to test it yet. I'll try to make some time this weekend.

[bondjimbond]

@mjordan Another ping about Diego's Piwik PR. Have you had a chance to test it properly?

[bondjimbond]

• ping *

[mjordan]

@bondjimbond I'm never going to get to this. I think I shlould transfer ownership of this repo to @DiegoPino like we discussed many months ago.

[DiegoPino]

Feel free to do. In that case, I can also change the name of the module since Piwik also did so.

[bondjimbond]

@DiegoPino Piwik is still a better name than Matomo! But yeah, must move with the times.

[mjordan]

@DiegoPino DiegoPino/islandora_piwik already exists - want me to rename mine first first, then transfer it?

[DiegoPino]

@mjordan let me rename mine. Give me a minute!

[DiegoPino]

Renamed to https://github.com/DiegoPino/islandora_piwikSOLR Go for it! I will care for your baby and raise it under the opensource values=)

[mjordan]

@DiegoPino Github is not letting me. I'm getting the error "DiegoPino already has a repository in the mjordan/islandora_piwik network". Not finding a lot of useful info on how to resolve that. In the meantime I've made you an admin on that repo. Will persist.

[DiegoPino]

@mjordan oh, I get it. It is not the name but the master v/s fork thing. I will move mine to /mnylc and will let you know once that is done. Thanks for pursuing this.

[DiegoPino]

@mjordan ok, it is gone. You should be able to transfer. thx.

[mjordan]

@DiegoPino thanks so much for taking over this module. I'm sorry I can't maintain all the things! It's in good hands now. :heart: