Include Empty Rows

[harshitgupta]

Hi,

First of all thank you for the module. Its one of the rare modules that

• support both xls and xlsx files
• gives the data cell by cell

One problem I found is that it ignores empty lines by default. My app's business logic requires me to pick up rows based upon user-given index values (which include empty lines).

It would be great if you could make it config based rather the current approach.

I looked into the code and found I need to comment following lines in order enable empty lines:

           // if (columnData === '') {
           //     continue;
           // }

        // Cleaning empty
        // rows = rows.filter(v => v !== null && v !== undefined);

Can you please confirm that I am not missing any other lines?

Thanks.

[DiegoZoracKy]

You are right. It does that by default. What do you think about a config to indicate when it should return the empty values (being the current behavior of not returning the empty the default value)?

As you are already on the right snippet of the code, would you like to implement it?

[harshitgupta]

Thank you for the confirmation. I will create the pull request soon.

[DiegoZoracKy]

Hi @harshitgupta,

Are you still interested in working on that? No pressure, just checking to see if we should keep this issue open.

[NunoChumbo]

Hi, i too need for the column value even if cell is empty, but as for the empty lines it may stay as it is. might consider this line if (cell == '!ref' || sheet[cell].v === undefined )

putting the right part || into configuration ([sheet[cell].v === undefined]), something like importnullvalues:true || false Thank you

[harshitgupta]

sorry for the delay but I just created the pull request.

Please let me know if you have any questions.

Thanks @NunoChumbo for the reminder.

[DiegoZoracKy]

Hi @ harshitgupta,

Thanks for creating the PR. It will handle very well this case. I just wrote one comment there that I would like to see your answer before merging it.

[harshitgupta]

@DiegoZoracKy Sure but I don't see any comment there.

Could you please point me to it?

[DiegoZoracKy]

Sure, it is on the changes section:

https://github.com/DiegoZoracKy/convert-excel-to-json/pull/20/files

[harshitgupta]

well, it's embarrassing. I still don't see it, neither did i get any notification for it. do you have to assign it to me or something?

[DiegoZoracKy]

That's weird. Anyway, here is the screenshot of it:

[harshitgupta]

On my side its looks like this:

no sign of any comment or anything.

But anyways to answer your question I would say that since we are dealing with array which starts with index of 0 and the row at line # 49 always start from 1 (assuming first line is not empty) as first cell will always be A1 in the same case. That means nothing ever will get assign to row[0], thus it will always be undefined.

Second it has never been a problem so far because in the existing using the following code you have been getting rid of rows that are null or undefined.

rows = rows.filter(v => v !== null && v !== undefined);

Please let me know if it makes sense.

[DiegoZoracKy]

Thanks for your answer and your PR @harshitgupta. It is already merged and published on npm (v 1.5.0)

@NunoChumbo might want to take a look.

[DiegoZoracKy]

PR merged: https://github.com/DiegoZoracKy/convert-excel-to-json/pull/20