search

Difegue / LANraragi

Web application for archival and reading of manga/doujinshi. Lightweight and Docker-ready for NAS/servers.
https://lrr.tvc-16.science
MIT License
2.18k stars 153 forks source link

"Pin this Category" in wrong #1006

Closed yushizui closed 3 months ago

yushizui commented 3 months ago

LRR Version and OS 0.9.1 docker Bug Details https://github.com/Difegue/LANraragi/issues/689 There seems to be an error in the category sorting after the update. It does not seem to be sorted according to the alphabetical order mentioned above, and the "Pin this Category" seems to be invalid. I don’t know if it has something to do with the use of Chinese.

yushizui commented 3 months ago

I just created a new docker and tried it, I think it's because the existing sorting method is not compatible with other language.

Would you consider compatibility with other languages,Seems like it could be solved by adding a letter to the front as well，I have quite a few Categories. If you consider compatibility, I won’t modify them for the time being.

Difegue commented 3 months ago

The sorting just relied on basic javascript comparison -- I've pushed a change to rely on localeCompare instead which might improve the situation for non-english languages.

No idea why pinning wouldn't work though -- Feel free to reopen this if you still have issues

yushizui commented 2 months ago

The sorting just relied on basic javascript comparison -- I've pushed a change to rely on localeCompare instead which might improve the situation for non-english languages.

No idea why pinning wouldn't work though -- Feel free to reopen this if you still have issues

pinning will only fail if other language is used.