search

Difegue / LANraragi

Web application for archival and reading of manga/doujinshi. Lightweight and Docker-ready for NAS/servers.
https://lrr.tvc-16.science
MIT License
2.18k stars 153 forks source link

Render HTML for summaries #968

Closed psilabs-dev closed 5 months ago

psilabs-dev commented 5 months ago

Support HTML rendering features for displaying summaries, such as new lines, font styles, hyperlinks, etc. Should be backwards compatible with text rendering.

There are some security concerns, mainly if scripts are found in the summary. In case one archive points to metadata containing a malicious summary. I think how to resolve this is up for debate; whether to sanitize client-side or server-side or both. But I think this would be a better visual experience.

not too familiar with JS

image

Difegue commented 5 months ago

Yeah I explicitly disabled this for security concerns; I'd rather not encourage people putting html in their summaries either since it means third-party clients would also need to parse/render HTML which is a massive can of worms.

Maybe markdown would be an acceptable in-between, but that still brings a burden of support on everyone.. Open to discussion tho

psilabs-dev commented 5 months ago

Fair enough. Pixiv illustration summaries use html so I'm more motivated to push this haha

There are some ways to address those issues, let's just put a pin in this for now