search

Difegue / LANraragi

Web application for archival and reading of manga/doujinshi. Lightweight and Docker-ready for NAS/servers.
https://lrr.tvc-16.science
MIT License
2.25k stars 160 forks source link

Fixed #983 The FAKKU plugin now works again. #984

Closed Nixis198 closed 5 months ago

Nixis198 commented 5 months ago

Simple fix for the FAKKU plugin problem found in #983 . Literally just a one character fix. From my testing, everything works the way it used too before FAKKU updated their website. I don't really ever make pull requests so I don't really know what else to put. Just let me know and I will do my best to fix it.

Nixis198 commented 5 months ago

@pandafeliz noticed that my fixed didn't work with automatic mode. The latest commit fixes that.

Nixis198 commented 5 months ago

I think the tests are out of date. They are from before FAKKU updated their website. I'm going to try to get LANraragi setup for development on my computer so I can test the tests without having to deploy to Github.

Difegue commented 5 months ago

Yeah, it's likely the sample HTML needs to be updated. Keep in mind you can use GH Codespaces, that might be faster for you.

Nixis198 commented 5 months ago

I discovered a major issue with the plugin. It only works if you are logged in on FAKKU using the login plugin providing your FAKKU sid. I am working on changing what the plugin looks for to get the tags

Nixis198 commented 5 months ago

I did update the test HTML file but currently the plugin will fail.

Difegue commented 5 months ago

Hasn't that been the case for a while? The login plugin is there to help circumvent the cloudflare block.

Nixis198 commented 5 months ago

Hasn't that been the case for a while? The login plugin is there to help circumvent the cloudflare block.

The reason for it to fail isn't directly caused by Cloudflare. The plugin looks for the "Suggest More Tags" button on the page to find the tags. If you are not logged in that button doesn't show up, so the plugin errors out.

With Cloudflare being an issue, I will change the plugin to throw an error if you are not logged in. I will also change the test to simulate being logged in, so it should pass.

Nixis198 commented 5 months ago

I added checks to make sure the user is logged in to FAKKU. The plugin will return an error if the proper cookie if not found. Because FAKKU accounts are free to make, I don't see this as a major setback for users. I did update the test HTML file to better represent the current FAKKU site (simulating that a user is logged in). I don't think any other changes are needed for this plugin.

Difegue commented 5 months ago

All looks good here. Thanks again!

holopin-bot[bot] commented 5 months ago

Congratulations @Nixis198, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxhsvusk156790cl9icyovah1

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!