Difegue / Stylophone

A pretty cool™️ MPD client in .NET. Based on MpcNET.
https://tvc-16.science/stylophone-27.html
MIT License
135 stars 10 forks source link

Selecting a playlist or album in library crashes the application #14

Closed xBelladonna closed 3 years ago

xBelladonna commented 3 years ago

It seems whenever I select a playlist from the sidebar or an album from the library, the application freezes and then crashes. It's able to list the stored playlists from the server but not open them, and able to list all albums in the library but not display the tracks within. Queue is working as expected. I have tried resetting the application through Windows settings and re-installing the application. Neither of these made a difference. Do you have any advice on where to begin debugging?

Difegue commented 3 years ago

I got a failure report from the MS Store which looks like it's linked to this issue:
image

StickyHeader is used in both the playlist and album views, so it certainly matches - I'm not quite sure what is causing the crash here however, looks like it's the animation? 🤔

Full stack trace below:

Frame   Image   Function    Offset
0   combase.dll RoOriginateError    0x0000000000000051  
1   dcomp.dll   wil::details::RaiseRoOriginateOnWilExceptions   0x000000000000008C  
2   dcomp.dll   wil::details::LogFailure    0x0000000000000169  
3   dcomp.dll   wil::details::ReportFailure 0x0000000000000095  
4   dcomp.dll   wil::details::ReportFailure_Hr  0x000000000000003F  
5   dcomp.dll   wil::details::in1diag3::Return_Hr   0x0000000000000029  
6   dcomp.dll   Windows::UI::Composition::CompositionAnimation::Api::SetReferenceParameter  0x0000000000058552  
7   FluentMPC.McgInterop.dll    __Interop::ComCallHelpers.Call  0x0000000000000089  
8   FluentMPC.McgInterop.dll    __Interop::ForwardComStubs.Stub_27_System.__Canon, System.__Canon_  0x00000000000000AC  
9   FluentMPC.McgInterop.dll    Windows::UI::Composition::CompositionAnimation.SetReferenceParameter    0x0000000000000024  
10  Microsoft.Toolkit.Uwp.UI.Animations.dll Microsoft::Toolkit::Uwp::UI::Animations::Expressions::ExpressionNode.SetAllParameters   0x0000000000000185  
11  Microsoft.Toolkit.Uwp.UI.Animations.dll Microsoft::Toolkit::Uwp::UI::Animations::Expressions::CompositionExtensions.CreateExpressionAnimationFromNode   0x000000000000005F  
12  Microsoft.Toolkit.Uwp.UI.Animations.dll Microsoft::Toolkit::Uwp::UI::Animations::Expressions::CompositionExtensions.StartAnimation  0x0000000000000033  
13  Microsoft.Toolkit.Uwp.UI.Animations.dll Microsoft::Toolkit::Uwp::UI::Animations::Behaviors::StickyHeaderBehavior.AssignAnimation    0x00000000000006A9  
14  Microsoft.Toolkit.Uwp.UI.Animations.dll Microsoft::Toolkit::Uwp::UI::Animations::Behaviors::StickyHeaderBehavior.ScrollHeader_SizeChanged   0x0000000000000009  
15  Microsoft.Toolkit.Uwp.UI, Version=6.1.0.0, Culture=neutral, Pub Microsoft::Toolkit::Uwp::UI::Behaviors::BehaviorBase$1_System::__Canon_.OnAssociatedObjectLoaded    0x000000000000001F  
16  System.Private.Xml.dll  System::Xml::Serialization::XmlNodeEventHandler.Invoke  0x000000000000002F  
17  FluentMPC.McgInterop.dll    __Interop::Intrinsics.HasThisCall__22_System.__Canon_   0x0000000000000037  
18  FluentMPC.McgInterop.dll    __Interop::ReverseComStubs.Stub_6_System.__Canon_   0x0000000000000071  
19  FluentMPC.McgInterop.dll    Windows::UI::Xaml::SizeChangedEventHandler__Impl::Vtbl.Invoke__n    0x0000000000000043  
20  Windows.UI.Xaml.dll DirectUI::CRoutedEventSourceBase_DirectUI::IUntypedEventSource,Windows::UI::Xaml::ISizeChangedEventHandler,IInspectable,Windows::UI::Xaml::ISizeChangedEventArgs_::Raise    0x00000000000000E8  
21  Windows.UI.Xaml.dll DirectUI::FrameworkElement::OnSizeChanged   0x000000000000003A  
22  Windows.UI.Xaml.dll DirectUI::DXamlCore::RaiseEvent 0x00000000000001BA  
23  Windows.UI.Xaml.dll CLayoutManager::RaiseSizeChangedEvents  0x00000000000001C9  
24  Windows.UI.Xaml.dll CLayoutManager::UpdateLayout    0x00000000000002A5  
25  Windows.UI.Xaml.dll CCoreServices::NWDrawTree   0x000000000000023E  
26  Windows.UI.Xaml.dll CCoreServices::NWDrawMainTree   0x00000000000000AD  
27  Windows.UI.Xaml.dll CWindowRenderTarget::Draw   0x000000000000006F  
28  Windows.UI.Xaml.dll CXcpBrowserHost::OnTick 0x0000000000000096  
29  Windows.UI.Xaml.dll CXcpDispatcher::Tick    0x000000000000008D  
30  Windows.UI.Xaml.dll CXcpDispatcher::OnReentrancyProtectedWindowMessage  0x0000000000000042  
31  Windows.UI.Xaml.dll CXcpDispatcher::WindowProc  0x0000000000000119  
32  Windows.UI.Xaml.dll CDeferredInvoke::DispatchQueuedMessage  0x00000000000000CB  
33  Windows.UI.Xaml.dll CXcpDispatcher::MessageTimerCallbackStatic  0x000000000000001C  
34  CoreMessaging.dll   System__Action$CallbackThunk    0x000000000000011B  
35  CoreMessaging.dll   Microsoft::CoreUI::Dispatch::TimeoutManager::Callback_OnDispatch    0x000000000000018B  
36  CoreMessaging.dll   Microsoft::CoreUI::Dispatch::EventLoop::Callback_RunCoreLoop    0x00000000000006FB  
37  CoreMessaging.dll   Microsoft::CoreUI::Dispatch::UserAdapter::OnUserDispatch    0x00000000000001D6  
38  CoreMessaging.dll   Microsoft::CoreUI::Dispatch::UserAdapter_DoWork 0x00000000000000F1  
39  CoreMessaging.dll   Microsoft::CoreUI::Dispatch::UserAdapter_WindowProc 0x00000000000000A3  
40  user32.dll  UserCallWinProcCheckWow 0x00000000000002F8  
41  user32.dll  DispatchClientMessage   0x000000000000009C  
42  user32.dll  __fnDWORD   0x0000000000000033  
43  ntdll.dll   KiUserCallbackDispatcherContinue    0x0000000000000000  
44  win32u.dll  ZwUserPeekMessage   0x0000000000000014  
45  user32.dll  _PeekMessage    0x0000000000000043  
46  user32.dll  PeekMessageW    0x0000000000000143  
47  Windows.UI.dll  Windows::UI::Core::CDispatcher::ProcessMessage  0x00000000000000AE  
48  Windows.UI.dll  Windows::UI::Core::CDispatcher::WaitAndProcessMessagesInternal  0x00000000000000C0  
49  Windows.UI.dll  Windows::UI::Core::CDispatcher::ProcessEvents   0x000000000000007B  
50  Windows.UI.Xaml.dll CJupiterWindow::RunCoreWindowMessageLoop    0x000000000000004C  
51  Windows.UI.Xaml.dll DirectUI::DXamlCore::RunMessageLoop 0x0000000000000047  
52  twinapi.appcore.dll Windows::ApplicationModel::Core::CoreApplicationView::Run   0x000000000000003A  
53  twinapi.appcore.dll _lambda_643db08282a766b00cec20194396f531_::operator 0x00000000000001EF  
54  SHCore.dll  _WrapperThreadProc  0x00000000000000E9  
55  kernel32.dll    BaseThreadInitThunk 0x0000000000000014  
56  ntdll.dll   RtlUserThreadStart  0x0000000000000021  
Difegue commented 3 years ago

I can actually repro this on the 1.4 build from the MS Store - I usually only use the version I build myself for development. 😁
More updates soon!

Difegue commented 3 years ago

Think I found the issue - Some overzealous optimizing for the .NET Native variant.
I didn't know much about the whole .NET Native ordeal when I added this in so I didn't think about the consequences on Store builds. 😳 I'll try to get a 1.4.1 published ASAP!

Difegue commented 3 years ago

1.4.1.0 is now live on the Store and I've verified the issue is fixed on my end.
Thanks for notifying me! Feel free to reopen if you still have issues.

xBelladonna commented 3 years ago

Goodness me, you don't waste time! Thank you very much! There are other issues that have popped up but I believe they are different so I'll open a new issue.