search

DiffEqML / torchdyn

A PyTorch library entirely dedicated to neural differential equations, implicit models and related numerical methods
https://torchdyn.org
Apache License 2.0
1.33k stars 124 forks source link

Bugs in the neuralde.py for NeuralODE class #172

Open Charlie-Xiaoqi opened 1 year ago

Charlie-Xiaoqi commented 1 year ago

When looking at the source code under /torchdyn/core/neuralde.py, I found that the NeuralODE class is missing defunc property. And this bug results in an error for /tutorials/module4-model/m4e_lagrangian_nets.ipynb. The notebook can not be run successfully because it requires NeuralODE class to have the defunc property.

shaido987 commented 1 year ago

I have also encountered this problem. Did you manage to solve this in any way?

amdee commented 1 year ago

Hey, @Zymrael do you mind providing insight on this issue, I know the neuralde.py API has changed according to the Changelog but I thought it was backward compatible. I think even when I tried to use the torchdyn older version like 0.31, 0.3, 0.4 and etc still the HNN and LNN examples won't run. Any input will be appreciated, Thanks

oselin commented 7 months ago

@Charlie-Xiaoqi @shaido987 @amdee one year later, the issue is not solved