DiffEqML / torchdyn

A PyTorch library entirely dedicated to neural differential equations, implicit models and related numerical methods
https://torchdyn.org
Apache License 2.0
1.38k stars 128 forks source link

Model require `forward` to have `*args, **kwargs` in 1.0.6 #203

Open atong01 opened 1 year ago

atong01 commented 1 year ago

torchdyn>=1.0.3 breaks if a model does not have *args, **kwargs in the forward method. This breaks downstream code which has custom models compatible with previous torchdyn versions. I propose to remove this requirement.

https://github.com/atong01/conditional-flow-matching/issues/60

Manaro-Alpha commented 2 months ago

@atong01 is there any solution to the above problem?

atong01 commented 2 months ago

I have added args and kwargs to all my models... This is far from ideal, but it's somewhat annoying to fix here and I haven't had time.