search

DiffSK / configobj

Python 3+ compatible port of the configobj library
https://configobj.readthedocs.org
Other
322 stars 76 forks source link

Allow other path-like objects as configspec #153

Closed WhyNotHugo closed 6 years ago

WhyNotHugo commented 7 years ago

Rather than just any str, allow any other path-like object (eg: pathlib.Path) as a configspec.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 81.399% when pulling f3a103f4a478ceb8d75575a11918c1f44bd32361 on hobarrera:path-like-configobjs into 7a0f1e06b5da72b1ed982720f79ffd3298243092 on DiffSK:master.

jhermann commented 7 years ago

BTW, the explicit use of pathlib is also what breaks Python 3.3.

WhyNotHugo commented 7 years ago

Cleaned up a bit. If this looks okay, I'll add explicit tests using pathlib.Path and other Pathlike objects.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 81.516% when pulling eedec9dbf263111de1f1d1a4fb2abac12a328d05 on hobarrera:path-like-configobjs into 7a0f1e06b5da72b1ed982720f79ffd3298243092 on DiffSK:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 81.516% when pulling eedec9dbf263111de1f1d1a4fb2abac12a328d05 on hobarrera:path-like-configobjs into 7a0f1e06b5da72b1ed982720f79ffd3298243092 on DiffSK:master.

WhyNotHugo commented 7 years ago

Bump?

WhyNotHugo commented 7 years ago

Bump? 🙂

labrys commented 6 years ago

Bump?

jhermann commented 6 years ago

Relies on https://www.python.org/dev/peps/pep-0519/

Please do add a test for it, ideally using a Pep519Mock object for Python <3.6 (or add a version check to the test).