Closed EiffL closed 3 years ago
Ok so I checked :-) and it doesnt work if I remove tfa-nightly from the setup.py, because it's needed for tfg, and tfg doesnt install it.
But, you have a point there :-) We need to have some tests to make sure things install and work correctly I'm gonna add one
@b-remy I reviewed my own code, just to show you that my PR was below standards on a number of points :-) I'll fix them and maybe ask you to do a second round of reviews.
Me closing documentations comments by saying we will fix it later with a specific documentation issue
This PR aims to close #1 and adds the tools needed to implement affine transformations in TensorFlow, and to generate the transformation needed for shear. I've updated the following notebook with an example of how to use the new API. It essentially looks like this:
Internally, I've added a few tools to handle generic affine transformations, this is going to be useful at some point when implementing WCS. I've used a matrix representation that allows for easy combination of different transformations into a new one.