Changes the API for cosmological parameters

DifferentiableUniverseInitiative / flowpm

Particle Mesh simulation in TensorFlow

https://flowpm.readthedocs.io/

MIT License

90 stars 20 forks source link

Changes the API for cosmological parameters #67

Closed EiffL closed 3 years ago

EiffL commented 3 years ago

This PR aims to solve #66 by creating a class that can be used to manipulate cosmological parameters.

!! Warning !! This introduces a breaking change in the FlowPM API, at the level of the lpt_init and nbody functions, which now take a cosmology object as their first argument. The reason for this is that otherwise, if the cosmology is left implicit in some places, it is very possible that people will end up with different cosmologies in different places of their code.

EiffL commented 3 years ago

I have also found and fixed a discrepancy in the cosmology we were using for testing from nbodykit, which was including neutrinos whereas we dont.