Differential / accounts-entry

Meteor sign up and sign in pages
http://github.differential.com/accounts-entry/
MIT License
305 stars 189 forks source link

change password feature #37

Open geekyme opened 10 years ago

geekyme commented 10 years ago

hello , great work on this package!

i think right now the package is missing the 'change-password' feature that is present in accounts-ui though. Unlike in accounts-ui dropdown menu, there's no way for the user to change his password after he sign in. If he wants to change his password he has to logout, go through the forgot password & reset password process before he gets to change his password.

any chance change password can be rolled out? thank you!

ryw commented 10 years ago

Yeah — I've started another project meteor-profile (https://github.com/BeDifferential/meteor-profile) that might be a better home to change password functionality, as I'd probably want that functionality from the user profile page, not the primary navigation.

Any thoughts on how/where you'd see this feature integrated?

geekyme commented 10 years ago

hmmm yeah that makes sense. I've checked out that project pretty solid work so far. At the moment though I see some form fields are actually hard coded. Would it be a better idea to dynamically produce form fields based on say... what the app creator has supplied in user.profile property?

Eg. Perhaps I have these things in user.profile: { tutorial: true, calendarDays: [ ...Array of dates... ],

}

Then I want meteor-profile to produce the form to edit these fields. Perhaps I should discuss this in the meteor-profile repository

ryw commented 10 years ago

Yeah it absolutely needs to be made dynamic — we've only begun using it on a few projects. Most recently I just ended up copying it into my project as a starter kit, which is lame :)

I'll always use accounts-entry in conjunction w/ meteor-profile, so it's OK to talk about integration issues here.

If you have any interest in contributing to either projects, jump right in :) We're super early on all this, the more the merrier.

geekyme commented 10 years ago

hurray. i'm writing a pattern myself on my project to deal with profile settings. so maybe i can do a PR if i have something workable. have you seen https://github.com/aldeed/meteor-autoform ? they have dynamic form generation, i used it in my CRUD app function.

ryw commented 10 years ago

Yeah I used autoform on one project that had big forms. The abstraction works well when using simple stuff, but can actually obfuscate code when you get off the golden path. In general I liked it tho.

queso commented 10 years ago

It is funny this came up while I was gone. @hellogerard and I talked about this very thing before Thanksgiving.

I think we should build a page and allow password changing unless you have Meteor-Profile installed... Then it should default to allow that one to serve up the change password page.

queso commented 10 years ago

So far, I did some light integration work to Meteor-profile package. It hooks in if it detects accounts-entry and set the profileRoute to be the route setup from Meteor-profile iron-router file.

I am still torn on if we should just say add meteor-profile, or add a change password page in here.

geekyme commented 10 years ago

I like to keep things as minimal as possible so i think following the default accounts-ui style would be nice (just a simple dropdown to change password).

that way people don't have to install meteor-profile just to get the change password function.

optionally when they install meteor-profile, they can change password in a profile page, along with other parts of their profile such as first name, last name, etc etc.