search

Differential / meteor-boilerplate

Boilerplate meteor app - starting point for meteor apps
http://github.differential.com/meteor-boilerplate/
873 stars 179 forks source link

Settings access is doing it wrong #65

Open deanrad opened 9 years ago

deanrad commented 9 years ago

The idea is that each setting has a key, and the correct settings file (or JSON) is passed in at process startup time, so your code would only contain

Meteor.settings.public.meta.title

not

Meteor.settings[Meteor.settings.environment].public.meta.title

It's seldom that production and dev settings ought to be in the same file anyway, since you don't want to check in prod settings to source control anyway.

ryw commented 9 years ago

@chicagogrooves i agree. @nickw you agree too? you committed this version...

nickw commented 9 years ago

Yeah this was never fully implemented and was still in the experimentation phase. @chicagogrooves feel free to open a PR.

deanrad commented 9 years ago

groovy, thanks! Sorry if that was a bit :trollface: