search

DiffusionMapsAcademics / pyDiffMap

Library for diffusion maps
MIT License
46 stars 14 forks source link

updated doc of swiss roll notebook accordingly. #13

Closed ralfbanisch closed 5 years ago

ralfbanisch commented 6 years ago

I think this last commit didn't make it into master.

ehthiede commented 6 years ago

It didn't. It's actually somewhat duplicated here

https://github.com/DiffusionMapsAcademics/pyDiffMap/commit/5043e31f341ec81a3d1a14da0bad436e3e757c28

so fortunately we don't have to release a pach :-).

Let's merge it into master.

ralfbanisch commented 6 years ago

What do you mean?

-Ralf

On 11. Dec 2017, at 17:17, Erik Henning Thiede notifications@github.com wrote:

It didn't. It's actually somewhat duplicated i

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ehthiede commented 6 years ago

My line of thought was that if we had accidentally pushed a broken example to the python repository, we might have to release a patch. Fortunately, what happened is that both you and I made the general change (changing mydmap.epsilon to mydmap.epsilon_fitted) twice. Since this happened before release, we don't need to release a patch. We just merge dev into master, and then continue developing.

ralfbanisch commented 6 years ago

what needs to be done here? Merge or close?

ehthiede commented 6 years ago

Close should be fine.

-Erik

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon Virus-free. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Mon, Dec 18, 2017 at 8:53 AM, Ralf Banisch notifications@github.com wrote:

what needs to be done here? Merge or close?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/DiffusionMapsAcademics/pyDiffMap/pull/13#issuecomment-352447514, or mute the thread https://github.com/notifications/unsubscribe-auth/AOnebtVgtGUZHlK9-AsLt87Dvqy44Sk3ks5tBnxrgaJpZM4Q9d4y .