Compatibility with scipy 1.0.0

DiffusionMapsAcademics / pyDiffMap

Library for diffusion maps

MIT License

47 stars 14 forks source link

Compatibility with scipy 1.0.0 #17

Closed ppxasjsm closed 5 years ago

ppxasjsm commented 5 years ago

Between scipy 0.19.0 and below and 1.0.0 logsumexp has been moved from scipy.misc to scipy.special.

This is currently not accounted for.

ehthiede commented 5 years ago

Hi Toni: Thanks for raising the issue. Just to make sure I understand, the issue here is that the scipy.special / scipy.misc difference breaks backwards compatibility for scipy versions earlier than 1.0.0?

ppxasjsm commented 5 years ago

Yep. That is exactly it!

ehthiede commented 5 years ago

Great. I added a tweak in the branch dev_old_scipy. Could you confirm that it fixes your problem?

ppxasjsm commented 5 years ago

Fixed things thanks! (And sorry for the slow reply I was distracted by other things. )

ehthiede commented 4 years ago

Quick follow up: as of today these changes have been pushed to master.