search

Diggsey / ijson

More efficient alternative to `serde_json::Value` which saves memory by interning primitive values and using tagged pointers.
Apache License 2.0
127 stars 14 forks source link

Correct `is_object` typo. #22

Closed kjschiroo closed 1 year ago

kjschiroo commented 1 year ago

It looks like there was a typo that made it so a IValue would be checked for its numerical-ness before being transformed into an object. This switches it to check for its object-ness. Addresses #21

Diggsey commented 1 year ago

Thanks, could you add a regression test?

kjschiroo commented 1 year ago

Sure! I've added a test in src/value.rs. Does that match the existing patterns of the project?

Diggsey commented 1 year ago

Perfect, thanks 👍

codecov-commenter commented 1 year ago

Codecov Report

Merging #22 (a80f70a) into master (f1305b9) will increase coverage by 0.16%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   48.65%   48.82%   +0.16%     
==========================================
  Files          10       10              
  Lines        3007     3009       +2     
==========================================
+ Hits         1463     1469       +6     
+ Misses       1544     1540       -4
Impacted Files Coverage Δ
src/value.rs 58.59% <100.00%> (+1.06%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.