DigiAssets Learn the protocol.

[DGBNOOB]

DigiAssets section

1. Learn the protocol The current embedded link goes to an older version of the DigiAssets Specifications dated 2019:

https://github.com/DigiByte-Core/DigiAssets-Protocol-Specifications/wiki/DigiAsset%20Scheme

v3 DigiAssets-Protocol-Specifications is dated 2021. No Translation needed-recommend updating the link to:

https://github.com/digiassetX/DigiAssets-Protocol-Specifications/blob/master/DigiAsset-Scheme.md

If you follow the link to DigiAssets Protocol Specifications from 2019 there was an issue opened titled Obsolete dated July 28, 2021. I see this as a needed update for anyone who is interested in working with v3 DigiAssets.

These are some of the differences that stand out.

[Sbosvk]

We need to confirm with @digiAssetX whether this documentation is up-to-date, and then we can issue a pull request to have the repo under DigiByte Core org updated.

[DGBNOOB]

Just received a message from DigiAssetX and the documentation is not complete. I'm not sure if this includes DigiAsset Core development but this issue should be put at the back of the line until the documentation is updated and complete.

[DGBNOOB]

Update on previous message DigiAsset Core documentation can be found at https://github.com/DigiAsset-Core.

[ycagel]

@Sbosvk Should we issue a new PR to resolve this?

[DennisPitallano]

Hi @DGBNOOB

Just to confirm, we only need to update the link for "DigiAssets Protocol on GitHub" from https://github.com/digiassetX/DigiAssets-Protocol-Specifications/blob/master/DigiAsset-Scheme.md to https://github.com/DigiAsset-Core, correct?

[DGBNOOB]

Yes, that would be the only change.

I want to add a little context for others reading, currently the digiasset protocol link directs you to the v1-v2 digiasset repository. v3 is the latest version with digiasset-core in alpha testing. @Sbosvk raised an issue to have the protocol update on the DigiAsset-Protocol-Specification repo on July 5, 2023. I think this should be updated on the website because it opens the door for more developers to implement DigiAsset-Core and possibly make contributions to it and making the DigiByte ecosystem more robust. Again this is the only change, from from v1-v2 specifications to digiasset-core.

[mctrivia]

I really need to finish the update. It didn't play nice with my ide so was a bit of a pain to change. I did document the protocol in great detail

Here https://github.com/DigiAsset-Core/DigiAsset_Core/blob/master/src/DigiAsset.cpp#L406 and here https://github.com/DigiAsset-Core/DigiAsset_Core/blob/master/src/DigiAssetRules.cpp#L16

[DGBNOOB]

@DennisPitallano then the change would now be to add link to DigiAsset.cpp and a link to DigiAssetRules.ccp in place of link to DigiAsset Protocol on Github. It would then read DigiAsset.cpp with link to repo and DigiAssetRules.ccp with link to repo in @mctrivia comment above instead of DigiAsset Protocol on Github

[DennisPitallano]

@DGBNOOB like this?

[DGBNOOB]

I think that should work, but obviously needs to get reviewed and then we can go from there.

[Sbosvk]

If we can just hold our horses for just a little bit on this there will hopefully be documentation ready by sometime next week, I am currently assisting Matthew in making it. I have a lot going on right now, I don't want to go into it here but @DGBNOOB is aware, so I don't know how much time I can put into it, but again, we will try to have something ready by sometime next week at the latest.

[DGBNOOB]

Sounds good @Sbosvk,

@DennisPitallano we can hold here on this issue until the documentation is ready.

[DennisPitallano]

Sure, my PR is in draft, I'll make it ready once the documentations are available.

[DGBNOOB]

Sounds excellent, Thank you to everyone in this conversation. I appreciate Matthew for sharing pertinent info on DigiAsset Core, I 100% value Sbosvk feedback and effort on this issue. Thank you Dennis for being patient and flexible through this process.

[ycagel]

Has the documentation been finished @Sbosvk? Thanks for all you are doing.

[mctrivia]

Yes there is a web server and docs here:

https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/web

DigiByte Core related docs: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/web/rpc

DigiAsset Core overrides and expansion: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/src/RPC/Methods

[ycagel]

Yes there is a web server and docs here:

https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/web

DigiByte Core related docs: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/web/rpc

DigiAsset Core overrides and expansion: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/src/RPC/Methods

We just need a PR for this to get it reviewed.

[DGBNOOB]

Yes there is a web server and docs here: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/web DigiByte Core related docs: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/web/rpc DigiAsset Core overrides and expansion: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/src/RPC/Methods

We just need a PR for this to get it reviewed.

@ycagel this issue is to have the URL link updated from the DigiAssets v1-v2 specification on GitHub which are outdated, to DigiAsset Core with the current version and developments to the protocol. I'm curious to why a PR is needed. The v1-v2 DigiAsset specification and repository are obsolete and that is where the website will direct anyone clicking the link on DigiByte .org. I think this is a setback for getting more developers working with v3 DigiAssets. This change is not to add DigiAsset-Core to the DigiByte-Core organization.

@DennisPitallano In my opinion the link should be labeled DigiAsset-Core and only (1) link https://github.com/DigiAsset-Core/DigiAsset_Core

@mctrivia please add your input on what the link should be labeled and if it goes to any specific file or folder.

Thank you all, lets move this forward.

[DGBNOOB]

@ycagel I think i might have read your last reply wrong, if your saying submit a PR to have this change made then disregard my comment. I did make a recommendation and we should wait for input before creating PR.

[DennisPitallano]

Yes there is a web server and docs here: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/web DigiByte Core related docs: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/web/rpc DigiAsset Core overrides and expansion: https://github.com/DigiAsset-Core/DigiAsset_Core/tree/master/src/RPC/Methods

We just need a PR for this to get it reviewed.

@ycagel this issue is to have the URL link updated from the DigiAssets v1-v2 specification on GitHub which are outdated, to DigiAsset Core with the current version and developments to the protocol. I'm curious to why a PR is needed. The v1-v2 DigiAsset specification and repository are obsolete and that is where the website will direct anyone clicking the link on DigiByte .org. I think this is a setback for getting more developers working with v3 DigiAssets. This change is not to add DigiAsset-Core to the DigiByte-Core organization.

@DennisPitallano In my opinion the link should be labeled DigiAsset-Core and only (1) link https://github.com/DigiAsset-Core/DigiAsset_Core

@mctrivia please add your input on what the link should be labeled and if it goes to any specific file or folder.

Thank you all, lets move this forward.

That makes sense @DGBNOOB . I've deployed the web documentation from my fork (https://github.com/DennisPitallano/DigiAsset_Core) to make it accessible directly on the web. You can view it here: https://digi-asset-core.vercel.app/.

I'll remove the related commit from my PR so we can address issue #121 on the main repository (https://github.com/DigiByte-Core/DigiByte.org/issues/121). We can create a new PR once this is resolved.

[DGBNOOB]

@mctrivia will need to take a look, this is a little more technical than I can understand. It looks like a developer who understands the RPC calls will know how to implement the protocol. I just have one question, will any changes @mctrivia makes to DigiAsset-Core automate onto this app?
Great job Dennis.

[mctrivia]

@DGBNOOB I am not sure what you mean by "changes automated on to this app"

[DGBNOOB]

@mctrivia thank you for the quick response. Like I said this is a little more technical than I understand. 6c1256a Looks like it adds a link to DigiAsset-Core repository and a link to all the RPC calls. If this looks good to you then we can recommend to have it approved so that it can be added to DigiByte .org.

[ycagel]

Resolved through PR https://github.com/DigiByte-Core/DigiByte.org/pull/125