DigiByte-Core / digibyte

DigiByte Core 7.17.3 - CURRENT (5-12-2021) - 8.22.0 Development
https://digibyte.org
MIT License
99 stars 61 forks source link

chainparamsseeds.h needs updating with static Tor seed nodes #146

Open saltedlolly opened 11 months ago

saltedlolly commented 11 months ago

There are currently no Tor nodes in chainparamseeds.h: https://github.com/DigiByte-Core/digibyte/blob/develop/src/chainparamsseeds.h

To better fortify DigiByte against attack we should add some static Tor nodes to this file.

The current DigiByte static nodes list is here: https://github.com/DigiByte-Core/digibyte/blob/develop/contrib/seeds/nodes_main.txt

For comparison, see the Bitcoin static nodes list here: https://github.com/bitcoin/bitcoin/blob/master/contrib/seeds/nodes_main.txt

More info here: https://github.com/DigiByte-Core/digibyte/tree/develop/contrib/seeds

ycagel commented 10 months ago

@saltedlolly Can this be closed since we merged #145?

saltedlolly commented 10 months ago

It would be sensible to keep it open as a reminder to add tor nodes.

JohnnyLawDGB commented 10 months ago

Wouldn't there need to be some Digibyte client side changes as well in order to handle connections from Tor network?

saltedlolly commented 10 months ago

I have not dived into exactly how to set it up for DigiByte yet, but I am pretty sure Tor integration is included. It was added to Bitcoin Core v0.21. https://bitcoin.stackexchange.com/questions/70069/how-can-i-setup-bitcoin-to-be-anonymous-with-tor

JohnnyLawDGB commented 10 months ago

I have not dived into exactly how to set it up for DigiByte yet, but I am pretty sure Tor integration is included. It was added to Bitcoin Core v0.21. https://bitcoin.stackexchange.com/questions/70069/how-can-i-setup-bitcoin-to-be-anonymous-with-tor

Thanks for the link, I missed that development on BitCoin Core and will put it on my list to attempt to understand. If only we had infinite time.

saltedlolly commented 10 months ago

I think it is a great feature to have in so much that it obscures the originating IP address of nodes on the network - good for better privacy. At some point in the new year I want to look into adding support to DigiNode Tools. Hopefully it can make setup automatic. It will also then give us some tor nodes we can add to this file.

ycagel commented 9 months ago

@saltedlolly Where do we stand on this?