search

DigiByte-Core / digibyte

DigiByte Core 7.17.3 - CURRENT (5-12-2021) - 8.22.0 Development
https://digibyte.org
MIT License
103 stars 62 forks source link

Coinbase Maturity #161

Closed ycagel closed 10 months ago

ycagel commented 10 months ago 
          Awesome you found this @barrystyle ! Thanks for the contribution. It looks like there might be a couple of other places where `COINBASE_MATURITY_2` needs added properly to fix the issue as @beggsdl mentioned above.

txmempool.cpp needs an additional COINBASE_MATURITY_2 entry: https://github.com/DigiByte-Core/digibyte/blob/1c2c6563b6d5e5170cb2fa85a7564657b4d91271/src/txmempool.cpp#L535-L538

Here is txmempool.cpp COINBASE_MATURITY_2 in 7.17.3: https://github.com/DigiByte-Core/digibyte/blob/258afaceba07a16b8cf3acefc5bf2ce70d213b68/src/txmempool.cpp#L522-L529

Also in src/wallet/wallet.cpp looks like we need change to COINBASE_MATURITY_2 as well: https://github.com/DigiByte-Core/digibyte/blob/1c2c6563b6d5e5170cb2fa85a7564657b4d91271/src/wallet/wallet.cpp#L2904-L2911

Here is what 7.17.3 shows: https://github.com/DigiByte-Core/digibyte/blob/258afaceba07a16b8cf3acefc5bf2ce70d213b68/src/wallet/wallet.cpp#L4419-L4426

V7.17.3 mentions COINBASE_MATURITY_2 in these locations: Screenshot 2024-01-08 at 12 09 48 PM

current 8.22 including this PR onlys shows COINBASE_MATURITY_2 in 3 places outside of tests: Screenshot 2024-01-08 at 12 10 57 PM

I can add additions on to this PR @barrystyle or you can modify yours. Just let me know.

Originally posted by @JaredTate in https://github.com/DigiByte-Core/digibyte/issues/157#issuecomment-1881677700

JaredTate commented 10 months ago

This should be resolved with https://github.com/DigiByte-Core/digibyte/pull/160