search

DigiByte-Core / digibyte

DigiByte Core 7.17.3 - CURRENT (5-12-2021) - 8.22.0 Development
https://digibyte.org
MIT License
98 stars 61 forks source link

Update amount_tests.cpp #201

Closed JaredTate closed 6 months ago

JaredTate commented 6 months ago

This PR fixes amount_tests.cpp unit test on Linux. This test passes on mac but not linux because it appears the compilers handle it differently. Seems to be an int32 vs 64 issue. The test worked great for BTC, but not DGB with a larger MAX_MONEY integer.

make check should now pass on all platforms.

You can read more about Unit Tests here: https://github.com/DigiByte-Core/digibyte/blob/develop/src/test/README.md

To Compile & Run Unit Tests:

  ./autogen.sh
  ./configure
  make -j 8
  make check

Run Specific Unit Test Fixed

cd src/test
./test_digibyte --run_test=amount_tests

Thanks to @Jongjan88 for pointing this out & testing the fix!

JaredTate commented 6 months ago

ACK Nice work. @JaredTate

Thank you for identifying this issue, working on a fix & testing it on Linux!