search

DigiByte-Core / digibyte

DigiByte Core 7.17.3 - CURRENT (5-12-2021) - 8.22.0 Development
https://digibyte.org
MIT License
98 stars 61 forks source link

Rename Satoshi to DigiSatoshi in QT #229

Closed saltedlolly closed 4 months ago

saltedlolly commented 6 months ago

Clearly renaming it to a DigiBit was proving controversial. This change now makes it match the current "official" name in the DgbWiki: https://dgbwiki.com/index.php?title=DigiByte#Subunits

I elected to leave the abbreviation as 'sat' rather than 'dSat' for now. I think we should either update the wiki to use the abbreviation 'sat', or update DigiByte Core to use dSat in another PR. That way the term is consistent.

JaredTate commented 6 months ago

I see no harm in making it unique to DGB at all. Would "DigiToshi" be better because it's shorter? Just spitballing ideas out loud.

saltedlolly commented 6 months ago

My main objective for this change is simply to make the term consistent everywhere it is used, as it has been called different things in different places. Since there was a lot of opposition to DigiBit, I thought maybe I should keep it simple and just rename it to match the name on the wiki. At least then it is consistent. @mctrivia and others pointed out that abbreviation "sat" is used fairly universally, which is a fair point, even if personally I would prefer a unique name. Calling it DigiSatoshi does mean that abbreviation fits, even if it's a bit of mouthful. If we call it DigiToshi it's not such a good fit for the abbreviation "sat". Just my 2c.

(Another option is "DigiSat" as I suggested on the Issue thread which is a bit shorter and fits the abbreviation, but seeing as they just get called "sats" anyway, I figured the full name of "DigiSatoshi" will do.)

mctrivia commented 6 months ago

Ah but the wiki has been proposed to be changed to fit everything else. Sat.

You definetly will fail in trying to standardise to anything but sat because all the 3rd party applications call sat.

saltedlolly commented 6 months ago

Ah but the wiki has been proposed to be changed to fit everything else. Sat.

You definetly will fail in trying to standardise to anything but sat because all the 3rd party applications call sat.

Which is why I left it as "sat".

That said Dgbwiki currently says they are called dSats or Digis, so if we are calling them "Sats" it should be updated to reflect that. Once this PR is merged I will do that so the name is consistent everywhere.

gto90 commented 4 months ago

cACK