DigiDago / moodle-format_softcourse

A course format for Moodle. This course format displays sections with only an image and an optional text on the course homepage. Users don’t see the detail of the section, for instance, resources or activities.
https://pimenko.com
1 stars 4 forks source link

pulse plugin incompatibility #123

Open SYoung3000 opened 4 months ago

SYoung3000 commented 4 months ago

Subject of the issue/enhancement/features

When using the pulse plugin alongside softcourse format, an error is thrown when trying to save the activity settings.. It appears the plugins interactor poorly. As I am unsure where the error resides, I've raised to both parties on their git.

Steps to reproduce

Create a course, set the course to softcourse. Add a Pulse activity. An error will be thrown.

The same error can also be triggered by setting another format, for example topics, then adding a pulse activity, and then switching the course format to softcourse.

Expected behaviour

the pulse activity should be added to the course

Actual behaviour

The following error is thrown

Stack trace: line 157 of /course/format/softcourse/classes/output/courseformat/content/section.php: Error thrown line 161 of /course/format/classes/output/local/content.php: call to format_softcourse\output\courseformat\content\section->export_for_template() line 86 of /course/format/classes/output/local/content.php: call to core_courseformat\output\local\content->export_sections() line 101 of /course/format/softcourse/classes/output/renderer.php: call to core_courseformat\output\local\content->export_for_template() line 104 of /course/format/classes/output/section_renderer.php: call to format_softcourse\output\renderer->render_content() line 49 of /course/format/softcourse/format.php: call to core_courseformat\output\section_renderer->render() line 276 of /course/view.php: call to require()

CrymSonir commented 4 months ago

Hello,

I confirm that this issue is likely on the SoftCourse side. It's a problem we encountered and addressed for the "label" activity, but it seems we need to find a more generic solution. Since Pulse operates similarly to the label, this activity triggers the same error.

We currently lack the free time to look into and address this type of problem, so I can't guarantee that we'll handle it in the coming days. A "workaround" I can suggest would be either to avoid having the Pulse activity first in the order of section activities, or to "hide for student", which allows you to avoid the problem.

Best regards,

The Pimenko Tech Team