DigiKlausur / e2xgrader

Addon for nbgrader
MIT License
6 stars 9 forks source link

[converters] autograded notebook perm is 644 or 664 for goupshared #85

Closed mhwasil closed 1 year ago

mhwasil commented 2 years ago

Autograded notebook is set to 444 (or 664 if groupshared is enabled), but this is not expected since the autograded version should be read-only (444), so that graders cannot change the autograded one.

If group shared is enabled, the perm of autograded version should stay 444 so that the feedback and submitted versions are the same, but this will create another problem in a group shared system as other graders won't be able to re-autograde the submissions. This change corresponds to this pr.

If 664 is used, we can still force the base converter setting to 444 in nbgrader_config, and set the default permission for generate_assignment and generate_feedback to 664, not 444 (otherwise the release version won't be editable).

Workaround: setup base permission to 444, and others to 664:

c.BaseConverter.permissions = 444
c.GenerateAssignment.permissions = 664
c.GenerateFeedback.permissions = 664
c.GenerateSolution.permissions = 664

Unresolved issue