search

DigiPen-Faculty / CProcessing

MIT License
29 stars 4 forks source link

Made many things unsigned that should have been to begin with. I expl… #2

Closed NovaSmoof closed 3 years ago

NovaSmoof commented 3 years ago

I modified vect.h so that the size and capacity were size_t because if anything is supposed to be a size type it is the size.

Changed for loops in CP_Text.c and CP_Sound.c to accomadate this

Modified for loops in CP_Image.c, CP_Input.c, CP_Math.c, CP_Random.c, and CP_Sound.c that were indexing into arrays with ints and not unsigned ints.

Modified CP_Image.c so that image_num and image_max were both unsigned as they both describe the size of an array.

For the "is valid" input functions I made them take a CP_BOOL because it simply made more sense to return a bool.

Beyond this I made it so that the gamepad index was an integer. I did this because it was the index into an array and you shouldn't have a negative index into an array.

I made frameCount an unsigned because you simply cannot have a negative amount of frames passed.

I wanted to make it so that image and screen width/height used unsigned, but sadly the libraries used integers.

NovaSmoof commented 3 years ago

I should have made the changes to vect.c and vect.h. Then beyond that I altered my const position to fit your guys style.