DigiPen-Faculty / CProcessing

MIT License
27 stars 3 forks source link

All sorts of changes, fixes, optimizations, and cleanup #3

Closed EComes-DigiPen closed 2 years ago

EComes-DigiPen commented 2 years ago

Please carefully look over all changes I've made. Some prominent ones include:

ianelsbree commented 2 years ago

Hi there, just wondering why you have added all of the image assets including the justin1.png and justin2.png images to the Processing_Empty release, as that seems like a release that should have fewer assets loaded with it relative to the Processing_Sample release.

EComes-DigiPen commented 2 years ago

Hi there, just wondering why you have added all of the image assets including the justin1.png and justin2.png images to the Processing_Empty release, as that seems like a release that should have fewer assets loaded with it relative to the Processing_Sample release.

Since I assumed that those assets are intended to be used as placeholders when developing a project, I figured that it wouldn't hurt to include them in the Processing_Empty project. One can remove them if they don't need or want them.

AEllinger commented 2 years ago

I haven’t had time to go through the whole thing in detail, but I wanted to make a few comments.

First, thanks for putting the effort into doing this! We appreciate people engaging with the project, whether or not we end up using all your contributions.

justinchambers-dp commented 2 years ago

Spoke with EComes and requested changes be split up to avoid hiding things under all the whitespace and formatting changes. There have already been excellent responses to items brought up in this PR, but I'll add some quick notes to confirm our stance:

Closing this PR in anticipation of updated changes.