DigiThinkIT / erpnext_foxycart_integration

Other
1 stars 9 forks source link

Installation issue with pip 10 #18

Open DavidMenting opened 5 years ago

DavidMenting commented 5 years ago

Installing the app with pip 10 fails: ERROR: Traceback (most recent call last): File "<string>", line 1, in <module> File "/home/frappe/frappe-bench/apps/erpnext_foxycart_integration/setup.py", line 3, in <module> from pip.req import parse_requirements ImportError: No module named req

A fix is easy, as seen at https://stackoverflow.com/questions/25192794/no-module-named-pip-req . Changing the line to the following fixes the problem:

try: # for pip >= 10 from pip._internal.req import parse_requirements except ImportError: # for pip <= 9.0.3 from pip.req import parse_requirements

I can create a pull request for this.

Alchez commented 5 years ago

Hey @DavidMenting, we actually are not maintaining this repo any longer, but feel free to make a PR :).