search

Digilent / Zybo-Z7-20-pcam-5c

53 stars 29 forks source link

AXI-Stream implementation no-no #9

Closed elodg closed 4 years ago

elodg commented 5 years ago

TVALID must not depend on TREADY.

https://github.com/Digilent/Zybo-Z7-20-pcam-5c/blob/c2df7053b24860441775d3d8dd375f2810701072/repo/local/ip/AXI_GammaCorrection/hdl/AXI_GammaCorrection.vhd#L223

IonutCatuna commented 4 years ago

I think you were referring to this comment from the AMBA® 4 AXI4-Stream Protocol Specification, Version 1.0, page 19: "A master is not permitted to wait until TREADY is asserted before asserting TVALID."

IonutCatuna commented 4 years ago

I fixed this issue in commit # b8548f8 on GitHub master branch.