Digilent / vivado-library

MIT License
570 stars 313 forks source link

PmodSD Makefile Error in Vitis #68

Open hthrun opened 2 years ago

hthrun commented 2 years ago

When I try to build a platform with PmodSD I get the following error:

"Running Make include in mb_0/libsrc/PmodSD_v1_0/src"

make -C mb_0/libsrc/PmodSD_v1_0/src -s include  "SHELL=CMD" "COMPILER=mb-gcc" "ASSEMBLER=mb-as" "ARCHIVER=mb-ar" "COMPILER_FLAG
S=  -O2 -c -mcpu=v11.0 -mlittle-endian -mno-xl-reorder -mno-xl-soft-mul -mxl-barrel-shift -mxl-pattern-compare" "EXTRA_COMPILER
_FLAGS=-g -ffunction-sections -fdata-sections -Wall -Wextra -fno-tree-loop-distribute-patterns"

The syntax of the command is incorrect.
make[2]: *** [Makefile:44: PmodSD_includes] Error 1
make[1]: *** [Makefile:42: mb_0/libsrc/PmodSD_v1_0/src/make.include] Error 2
make: *** [Makefile:18: all] Error 2
Failed to build  the bsp sources for domain - standalone_mb_0
Failed to generate the platform.
Reason: Failed to build  the bsp sources for domain - standalone_mb_0
    invoked from within

Commenting out the following lines in the PmodSD Makefile allowed the compile to work, but I'm not sure if this is the desired fix:

${IPNAME}_includes:
       ${CP} ${INCLUDEFILES} ${INCLUDEDIR}
#      if not exist $(INCLUDEDIR)/utility md $(INCLUDEDIR)/utility
#      ${CP} utility/*.h $(INCLUDEDIR)/utility
Millies-ngc commented 2 years ago

This error appears to be caused by missing double quotes around the directories.

Millies-ngc commented 2 years ago

See PR https://github.com/Digilent/vivado-library/pull/70 that should fix the issue.