search

Digine-Labs / rosettanet

Ethereum <> Starknet RPC middleware.
MIT License
34 stars 27 forks source link

refactor: Add Uint256ToU256 and U256toUint256 functions for integer conversions #126

Closed YakupAltay closed 1 month ago

YakupAltay commented 1 month ago

https://github.com/keep-starknet-strange/rosettanet/issues/122

Hey @ermvrs! 👋 I've added tests for U256toUint256. Could you please check it out?

ermvrs commented 1 month ago

Do we need to return padded results from U256toUint256?

YakupAltay commented 1 month ago

Oh, you're right. Since the issue description says to focus on tests, I followed it, but the function does not return a padded result. I will make a few changes to the function, is that ok?

YakupAltay commented 1 month ago

Could you please check the last commit out @ermvrs?