search

Digine-Labs / rosettanet

Ethereum <> Starknet RPC middleware.
MIT License
34 stars 27 forks source link

Add RPC function and test #81

Closed muheebyusufbaba1 closed 4 months ago

muheebyusufbaba1 commented 6 months ago

Closes https://github.com/keep-starknet-strange/rosettanet/issues/69

AryanGodara commented 5 months ago

69

Write closes #69 so github can detect you're working on that issue ;)

muheebyusufbaba1 commented 5 months ago

All comments raised have been fixed @AryanGodara

AryanGodara commented 5 months ago

All comments raised have been fixed @AryanGodara

Awesome!

Also,

PARAMETERS:
QUANTITY|TAG - a block number, or the string "earliest", "latest" or "pending"
QUANTITY - the transaction index position.

Does the current implementation support me passing earliest, latest, and pending?

I think the validateBlockNumber function needs to be updated, and tests need to be added for these cases once you add this functionality

ermvrs commented 4 months ago

please resolve conflicts