search

DigitPaint / roger

Roger is your friendly front-end development toolbox!
MIT License
4 stars 4 forks source link

Feature url relativizer #28

Closed dannycobussen closed 9 years ago

dannycobussen commented 9 years ago

Fixes #25 and add minimal test for the url relativizer. Also includes Edwin's changes due the code coverage.

edwinvdgraaf commented 9 years ago

Thanks for your contribution. Sadly travis doesn't agree, that it really fixes the problem.

Also I've added a few notes, but let me stress out I am not an expert on testing, so these should be taken with grain of salt.

flurin commented 9 years ago

This pull request contains quite some changes in one commit. Also some unwanted functional behaviour (see comments on log/debug by edwinvdgraaf)

Using an instance variable to make it accessbile to other functions like this is bad practice. In it's current state it is set somewhere in the process and depending on that it "works".

As discussed IRL; I will make a better test setup for processors that can be re-used.

flurin commented 9 years ago

Thank you for the contribution. A fix has since been merged in #31.