search

Digital-Asset-Developer-Resources / aws

AWS required enviroment
GNU General Public License v3.0
0 stars 2 forks source link

Update Network.ipynb #9

Closed kenricnelson closed 4 years ago

kenricnelson commented 4 years ago

Tested Network.ipynb and found a couple issues requiring changes

1) In 'import boto3' profile_name='blockchain-node' changed to profile_name='default', since most users will not have setup a specific profile;

2) In 'Create Subnets' the variable SUBNET was not defined. Defined this as "SUBNET = AWS-SUBNET-LOCATION" ; however, I think we need to come up with a consistent method for specifying where the user is expected to edit, and possibly provide a default option, which in this case could be us-east-2;

3) Also in 'Create Subnets' changed the Name Tag to PREFIX + \"snp\"

StephenHarrington commented 4 years ago

The aws repo is deprecated. Please, see the cloud/aws folder in the resources repo for the current version and the python/Network.ipynb notebook that is the latest version.

kenricnelson commented 4 years ago

okay

On Wed, Jan 22, 2020 at 3:27 PM Stephen Harrington notifications@github.com wrote:

Closed #9 https://github.com/Digital-Asset-Developer-Resources/aws/pull/9.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Digital-Asset-Developer-Resources/aws/pull/9?email_source=notifications&email_token=AJD5LBCHEXIHJH3J54RAAUDQ7BQUNA5CNFSM4KITQUS2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWEHAGFA#event-2970485524, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJD5LBCM56XKTQWBQORXXGDQ7BQUNANCNFSM4KITQUSQ .