search

Digital-Forensics-Discord-Server / TheHitchhikersGuidetoDFIRExperiencesFromBeginnersandExperts

The official repo for a project involving a crowdsourced DFIR book. The main purpose of this book is to give anyone interested an opportunity to write a chapter of a book to get their name out there, get a publication on their resume with an actual ISBN number, and ideally lower the bar for people to contribute something back to the DFIR Community. Want to write a chapter? Let me know and let's make it happen!
MIT License
185 stars 22 forks source link

copyedited to "## Hash Extraction Techniques" #182

Closed hollykennedy closed 1 year ago

hollykennedy commented 1 year ago

Pushing this to make sure the style changes aren't objectionable to the author -- I made some pretty substantial changes to hopefully improve readability. It's so dense with good info!

AndrewRathbun commented 1 year ago

@FullTang you wanna take a peek?

hollykennedy commented 1 year ago

Pushing this to make sure the style changes aren't objectionable to the author -- I made some pretty substantial changes to hopefully improve readability. It's so dense with good info!

That is, I only did a few paragraphs, just down to the section "## Hash Extraction Techniques," in case these edits aren't sitting right with @FullTang

FullTang commented 1 year ago

@hollykennedy I like your style! It looks like my writing style is a bit wordy and you have figured out a way to condense what I was trying to say while keeping the key elements and getting the message across. I noticed a couple of typos and a small issue where it would not be technically accurate based on the way you rewrote it, but overall I like the changes! Feel free to dive into the rest of the chapter, if you so choose.

Thank you!

AndrewRathbun commented 1 year ago

Great collaboration, both! Cheers! @hollykennedy let me know if you want this merged now, or we can keep it open while you finish up and review from there. I'm cool with whatever.

FullTang commented 1 year ago

Oh, and Gov Crack has rebranded itself or been discontinued altogether, so we can remove that suggestion from this chapter.

hollykennedy commented 1 year ago

Great collaboration, both! Cheers! @hollykennedy let me know if you want this merged now, or we can keep it open while you finish up and review from there. I'm cool with whatever.

Let's leave it open until I'm done, thanks! Working on being a bit more careful so I don't break the content itself while I edit.

AndrewRathbun commented 1 year ago

I will close this for now. We can reopen anytime, if needed