Digital-Humanities-Quarterly / dhq-journal

DHQ is an open-access, peer-reviewed journal of digital humanities.
http://www.digitalhumanities.org/dhq/
11 stars 5 forks source link

Broken redirects #39

Open jawalsh opened 1 year ago

jawalsh commented 1 year ago

Redirects generated in cocoon are mysteriously broken. I don't see any recent changes to the sitemap.xml that could be causing this. In fact the sitemap was last changed four months ago, and the redirects were working until the last few days.

http://digitalhumanites.org/dhq/editorial and http://digitalhumanites.org/dhq/editorial/indesx.html should redirect to http://digitalhumanites.org/dhq/editorial/login.html. Instead, they redirect to http://digitalhumanities.org/dhq/editorial//editorial/login.html?resource=%2Fdhq%2Feditorial%2F. Notice the weird repetition of editorial in the new URL.

Similarly, the XML links at the top and bottom of all articles were broken. For instance, http://digitalhumanities.org/dhq/vol/9/3/000227.xml should redirect to http://digitalhumanities.org/dhq/vol/9/3/000227.xml But instead we get URL below, with a crazy repetition of the directory structure. I fixed the XML links with a recent @commit, but I'm not sure why this fix was necessary, and I'm not yet sure how to implement a similar fix for the editorial redirects. It all worked before.

I'm tagging @elibooklover @joelsjlee and @simonwiles in case any of you are aware of any code or server config changes that might have caused this redirect problem.

http://digitalhumanities.org/dhq/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/000227/000227.xml/vol/9/3/000227.xml/vol/9/3/000227/0

simonwiles commented 1 year ago

I'm not aware of any server config changes that could be relevant, I'm sorry. I can implement a server-level redirect for the editorial routes if desired (as a temporary or permanent solution) -- presumably there's a Cocoon-level solution too, but I've not looked at that.

The server-level config is a straightforward nginx location block of proxy_pass / proxy_redirect statements routing traffic to the tomcat installation, fwiw.

joelsjlee commented 1 year ago

I'm not aware of any code changes that could have affected this, but just by poking around it seems as though all the other editorial related urls listed in the sitemap that are pattern matched and then subsequently checked for authentication also fail when you are not logged in (For example going to http://digitalhumanities.org/dhq/editorial/bios.html gives http://digitalhumanities.org/dhq/editorial/bios.html/editorial/login.html?resource=%2Fdhq%2Feditorial%2Fbios.html). If you are logged in then none of these issues occur as far as I have seen. Perhaps it is an issue with the <map:redirect-to uri="login.html"/> that appear in the site map for all of these cases, but if it was working beforehand, I can't seem to figure out why it is not anymore.

As an additional note it seems like digitalhumanities.org/dhq/editorial redirects to http://digitalhumanities.org/dhq/editorial/editorial//editorial/editorial/login.html?resource=%2Fdhq%2Feditorial%2Feditorial%2F whereas digitalhumanities.org/dhq/editorial/ with the final backslash, redirects to http://digitalhumanities.org/dhq/editorial//editorial/login.html?resource=%2Fdhq%2Feditorial%2F. Not sure what this means, but from my parsing I think this falls into the pattern matching starting on line 633 of the sitemap entitled "pattern to access editorial toc". Sorry I couldn't be of more help, but let me know if I can.