Digital-Humanities-Quarterly / dhq-journal

DHQ is an open-access, peer-reviewed journal of digital humanities.
http://www.digitalhumanities.org/dhq/
10 stars 5 forks source link

tables inside figures get deleted #55

Open sydb opened 7 months ago

sydb commented 7 months ago

@juliaflanders on Slack:

In a few cases where the original .docx file has a table, TEIGarage for some reason has embedded the <table> elements inside <figure> (which is weird, but OK…). The problem comes in when I then run DHQ’s conversion, which deletes the embedded <table> and leaves an empty <figure>.

This is probably related to #49 (and maybe #48), but I am ignoring those for now and just trying to squash immediate bug.

Questions (for @juliaflanders or @jawalsh, I presume):

  1. If the TEIGarage output presents a <table> in a <figure>, should the output be a <table> in a <figure> or just a <table>?
  2. convert_tei2hq (deliberately?) removes the description of a graphic (whether in a <figure> or not). Is that a feature to be kept or an oversight to be corrected?