amclark42
commented
2 weeks ago This looks fantastic, @joelsjlee! The recommendations look a whole lot more approachable without the pipe characters. It's still a lot of information that can make people's eyes glaze over, but I think that putting the contributors last is a pretty decent compromise. People reading visually can skim for the next link, and people using assistive technology can navigate to the next list item without losing valuable information about, say, the publication year.
@sydb, what do you think?
Hi this is a PR for the
static_site_generation, pertaining to the conversation that the collaborative editors had about making the authors and their affiliations in the recommendation box similar in style to the search results and issue pages. Whereby we move away from the pipe separation of authors followed by the pipe separation of affiliations, and have each author and their affiliation separated by a comma, and each unit of author-affiliation separated by a semicolon.Most of the work of generating the TSVs in such a way was done in Haining's repo that generates the recommendations (PR here). This PR updates the TSVs to add the "Authors with Affiliations" column, and adjusts the
dhq2html.xslindexing of the TSVs accordingly.Syd pointed out some files where the affiliations are not listed, and the TSVs are formatted to handle those cases as well. For an example, look at article 000168 titled "Mining for the Meanings of a Murder: The Impact of OCR Quality on the Use of Digitized Historical Newspapers" in 2014, Volume 8.1. This article has an author with no affiliation. To see it recommended in a box, check out article 000268 titled "Machine Reading the Primeros Libros" in 2016, Volume 10.4. It is the first SPECTER recommendation. As you will see, the way it is formatted in the box is the same as it is formatted on the issue page and the search results.