Open amclark42 opened 5 days ago
BUILD FAILED
/home/syd/Documents/dhq-journal/build.xml:286: Directory does not exist: /home/syd/Documents/dhq-static/dhq-proofing
I am going to create that directory so I can continue testing. (As you might have guessed, I am testing the commandline interface, using bash.)
@sydb Good catch, thank you! I fixed that bug.
I've tested the three scenarios and they all seem to work as planned :-) To respond to Ash's questions above:
vol/
layer?
Besides reviewing my code changes, I’d like my reviewer(s) to try using the
makeInternalPreview
build target in the command line, as well as the exported oXygen scenarios. I’d like to know:Background
The main goal here: to allow DHQ editors and continuous integration to generate a proofing copy of the articles listed in the “editorial” section of the DHQ TOC. This is accomplished with a new Ant build target,
makeInternalPreview
.makeInternalPreview
allows the user to choose between generating a copy of just the unpublished articles (the default), or the entire DHQ site plus the internal preview section. Under the hood, the target customizes the behavior ofgenerateIssues
andgenerateSite
. In either case, the results are saved todhq-proofing
, a new directory insidedhq-static
.Other improvements
Because DHQ editors will use the new Ant build target in oXygen, I’ve made a few improvements:
common/xslt/static-site.scenarios
. Once imported, an oXygen user will be able to run themakeInternalPreview
,previewArticle
, orzipPreviewArticle
scenarios from any file in their local copy ofdhq-journal
.article_list.xsl
, the stylesheet which produces a table of all DHQ articles in the TOC for proofing purposes. The resulting HTML seems cleaner and more useful (to me, anyway), and the stylesheet itself should be significantly easier to read, understand, and maintain.I’ve also tried to aid maintainability by moving the
ant help
documentation into a single<echo>
(making its contents easier to read and edit). I also broke out the Ant property${toDir}
into three settings in thebuild-properties.xml
, so that individual directory names will be easier to edit. And I added a toggle to turn off certain XSLT messages where they would only distract from more useful info or urgent warnings.