search

Digital-Preservation-Finland / dpres-siptools

Pre-Ingest Tool for creating submission information packages
GNU Lesser General Public License v3.0
22 stars 8 forks source link

Add support for creatingApplicationName and creatingApplicationVersion #12

Closed ssairanen closed 1 year ago

ssairanen commented 2 years ago

Parameters for adding more creating application info

jmlehton commented 1 year ago

Your pull request has been reviewed and accepted in commit https://github.com/Digital-Preservation-Finland/dpres-siptools/commit/a7c029206ab299f139ac985a8c81cc4e79b5b557. However, we changed the functionality in later commits so that there is now one option parameter with two values instead of two separate options, i.e. --creating_application <name> <version>. This is more aligned with other options of the script, such as --checksum <algorithm> <sum>, --file_format <mime> <version>, --format_registry <name> <key>, and --identifier <type> <value>. We hope that this minor functional change is ok for you and thank you for the pull request.