Fix issue 315: Use packaging.version.Version instead of dsdev-utils.helpers.Version

Digital-Sapphire / PyUpdater

Pyinstaller auto-update library

https://www.pyupdater.org

460 stars 92 forks source link

Closed dennisvang closed 2 years ago

dennisvang commented 2 years ago

This is an attempt to fix issue #315 (and issue #299).

replaced the dsdev-utils.helpers.Version by a PyuVersion class which is a very thin wrapper around packaging.version.Version: just adds ability to convert from/to pyupdater "internal" version, which is used as keys in the versions.gz and config.pyu files.
pass around (and work with) Version objects instead of version strings, where possible
added some tests
renamed some variables for consistency and clarity

JessicaTegner commented 2 years ago

JMSwag commented 2 years ago

This looks great so far!

dennisvang commented 2 years ago

@JMSwag Many tests are still failing at this point, but that is due to other open issues. I fixed some of those in PR #309 and PR #313.

Would you prefer to keep those PRs separate, per issue, or should I merge them and create a single PR?

For comparison, my dev branch has all currently open PRs merged together.

JMSwag commented 2 years ago

@dennisvang I wouldn't mind a single combined PR.

dennisvang commented 2 years ago

@dennisvang I wouldn't mind a single combined PR.

@JMSwag allright, I combined this with several other interdependent pull requests into one: PR #322