Digital-Sapphire / PyUpdater

Pyinstaller auto-update library
https://www.pyupdater.org
459 stars 90 forks source link

Fix multiple issues related to release 4.0 #322

Closed dennisvang closed 2 years ago

dennisvang commented 2 years ago

This should fix the following issues:

codecov[bot] commented 2 years ago

Codecov Report

Merging #322 (6e79a0c) into main (7093d76) will increase coverage by 0.27%. The diff coverage is 93.06%.

:exclamation: Current head 6e79a0c differs from pull request most recent head 1353b55. Consider uploading reports for the commit 1353b55 to get more accurate results

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   88.14%   88.41%   +0.27%     
==========================================
  Files          26       26              
  Lines        2336     2314      -22     
==========================================
- Hits         2059     2046      -13     
+ Misses        277      268       -9     
Impacted Files Coverage Δ
pyupdater/client/__init__.py 89.17% <88.88%> (+0.80%) :arrow_up:
pyupdater/core/package_handler/package.py 80.00% <89.65%> (-2.45%) :arrow_down:
pyupdater/client/patcher.py 83.58% <90.47%> (+0.90%) :arrow_up:
pyupdater/client/updates.py 87.19% <92.30%> (-3.00%) :arrow_down:
pyupdater/core/package_handler/__init__.py 92.66% <92.30%> (+1.45%) :arrow_up:
pyupdater/cli/options.py 100.00% <100.00%> (ø)
pyupdater/core/key_handler/keys.py 83.17% <100.00%> (ø)
pyupdater/core/package_handler/patch.py 86.79% <100.00%> (ø)
pyupdater/settings.py 100.00% <100.00%> (ø)
pyupdater/utils/__init__.py 86.79% <100.00%> (+1.74%) :arrow_up:
... and 5 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

dennisvang commented 2 years ago

@JMSwag Is there anything I can do to get this PR approved?

its-monotype commented 2 years ago

When Pyupdater 5?

its-monotype commented 2 years ago

@JMSwag When PR will be approved??? We can't use Pyupdater without this fixes from this amazing guy